chamikaramj commented on a change in pull request #11086: [BEAM-8910] Make 
custom BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r409025802
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery.py
 ##########
 @@ -610,7 +611,8 @@ def __init__(
       coder=None,
       use_standard_sql=False,
       flatten_results=True,
-      kms_key=None):
+      kms_key=None,
+      use_json_exports=False):
 
 Review comment:
   Is there a reason to continue supporting JSON for the new transform (once we 
get our current performance issues) ? Probably we should document why users may 
choose JSON over Avro if we want to support both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to