suztomo commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io
URL: https://github.com/apache/beam/pull/11151#discussion_r409058454
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -469,6 +470,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_cloud_datastore_v1_proto_client :
"com.google.cloud.datastore:datastore-v1-proto-client:1.6.3",
google_cloud_spanner :
"com.google.cloud:google-cloud-spanner:$google_cloud_spanner_version",
google_http_client :
"com.google.http-client:google-http-client:$google_http_clients_version",
+ google_http_client_gson :
"com.google.http-client:google-http-client-gson:$google_http_clients_version",
Review comment:
Do you really need google_http_client_gson here? Beam already has
google_http_client_jackson2 and it seems CloudHealthcare.Builder accepts
Jackson.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
