tvalentyn commented on a change in pull request #11431: [BEAM-8646] Fix
external environment on OS X as well.
URL: https://github.com/apache/beam/pull/11431#discussion_r409186220
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
##########
@@ -614,8 +615,8 @@ def stop_worker(self):
pass
def host_from_worker(self):
- # TODO(BEAM-8646): Reconcile the behavior on Windows platform.
- if sys.platform == 'win32':
+ # TODO(BEAM-8646): Reconcile the across platforms.
Review comment:
nit: extra 'the'.
Also, can you please comment on the bug which issues it causes on OS X?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
