mxm commented on a change in pull request #11154: [BEAM-1819] Key should be 
available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r410197549
 
 

 ##########
 File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
 ##########
 @@ -837,11 +837,15 @@ public void onProcessingTime(InternalTimer<ByteBuffer, 
TimerData> timer) {
 
   // allow overriding this in ExecutableStageDoFnOperator to set the key 
context
   protected void fireTimerInternal(Object key, TimerData timerData) {
 
 Review comment:
   ```suggestion
     protected void fireTimerInternal(ByteBuffer key, TimerData timerData) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to