lostluck commented on a change in pull request #11443: [BEAM-9775] Add Go
support for SDF StandardRequirements.
URL: https://github.com/apache/beam/pull/11443#discussion_r410386598
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate_test.go
##########
@@ -87,29 +89,38 @@ func TestMarshal(t *testing.T) {
name string
makeGraph func(t *testing.T, g *graph.Graph)
edges, transforms, roots int
+ requirements []string
}{
{
name: "ParDo",
makeGraph: func(t *testing.T, g *graph.Graph) {
- addDoFn(t, g, pickFn, g.Root(),
[]*graph.Node{newIntInput(g)}, []*coder.Coder{intCoder(), intCoder()})
+ addDoFn(t, g, pickFn, g.Root(),
[]*graph.Node{newIntInput(g)}, []*coder.Coder{intCoder(), intCoder()}, nil)
},
edges: 1,
transforms: 1,
roots: 1,
}, {
name: "ScopedParDo",
makeGraph: func(t *testing.T, g *graph.Graph) {
- addDoFn(t, g, pickFn, g.NewScope(g.Root(),
"sub"), []*graph.Node{newIntInput(g)}, []*coder.Coder{intCoder(), intCoder()})
+ addDoFn(t, g, pickFn, g.NewScope(g.Root(),
"sub"), []*graph.Node{newIntInput(g)}, []*coder.Coder{intCoder(), intCoder()},
nil)
},
edges: 1,
transforms: 2,
roots: 1,
+ }, {
+ name: "SplittableParDo",
Review comment:
While this is testing the Marshal it's not validating that the Requirements
are populated as expected. Consider checking the new change in the resulting
proto, if not the length like the other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
