lukecwik commented on a change in pull request #11448: [BEAM-3836] Enable
dynamic splitting/checkpointing within the Java SDK harness.
URL: https://github.com/apache/beam/pull/11448#discussion_r410553899
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -340,7 +347,12 @@ private void
createRunnerAndConsumersForPTransformRecursively(
"Unable to find active bundle for instruction id %s.",
request.getProcessBundleSplit().getInstructionId()));
}
- throw new UnsupportedOperationException("TODO: BEAM-3836, support
splitting within SDK.");
+ BeamFnApi.ProcessBundleSplitResponse.Builder response =
+ BeamFnApi.ProcessBundleSplitResponse.newBuilder();
+ for (BeamFnDataReadRunner channelRoot : bundleProcessor.getChannelRoots())
{
+ channelRoot.trySplit(request.getProcessBundleSplit(), response);
Review comment:
Yes, each root gets the full split request and extracts out the desiredsplit
information for itself if there is any specific to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
