lostluck commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-616002822 I think i tried previously and they wouldn't stick on regeneration so I've already submitted a change to ignore the go.sum files in the license check. Note that I did ask for licenses to be put on the files earlier, so i assume you just ran into the same problem i did. They're important information in that it's checksums for the versions indicated in the go.mod file, but they're ultimately automatically derived from files with licenses, so this should be fine. On Sat, Apr 18, 2020, 6:30 PM Damon Douglas <[email protected]> wrote: > Thank you for letting me know. 😨 @lostluck <https://github.com/lostluck> > Should we put the license information in the go.sum files? And yes that > README on how to keep the go katas up to date will be helpful. I created > BEAM-9782 <https://issues.apache.org/jira/browse/BEAM-9782> subtask so > its not forgotten. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/11340#issuecomment-616002270>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFORKN56JIQNUUPYIHLRNJH4DANCNFSM4MDS5PKQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
