TheNeuralBit commented on a change in pull request #11264: URL: https://github.com/apache/beam/pull/11264#discussion_r411527956
########## File path: sdks/python/apache_beam/dataframe/convert.py ########## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from __future__ import absolute_import + +import inspect + +from apache_beam import pvalue +from apache_beam.dataframe import expressions +from apache_beam.dataframe import frame_base +from apache_beam.dataframe import transforms + + +def to_dataframe(pc): + pass + + +# TODO: Or should this be called as_dataframe? Review comment: Yeah definitely fair to not make changes to PCollection yet. Another option would be methods on DeferredDataframe, like #as_pcollection(): ```python pcol = p | "Read from Source" >> beam.io.SomeSchemaSource(foo) df = to_dataframe(pcol) df_agg = df[df["measurement" > threshold]].groupby("id").count() df_agg.as_pcollection() | "Write to Sink" >> beam.io.SomeSink(bar) ``` This is just a bikeshed though. This is still very experimental so I don't think we're locking ourselves into anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
