ananvay commented on a change in pull request #11466:
URL: https://github.com/apache/beam/pull/11466#discussion_r411762393



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1182,6 +1188,11 @@ def run_Read(self, transform_node, options):
         raise ValueError(
             'BigQuery source is not currently available for use '
             'in streaming pipelines.')
+      debug_options = options.view_as(DebugOptions)
+      use_fn_api = (debug_options.experiments and
+                    'beam_fn_api' in debug_options.experiments)
+      if use_fn_api:

Review comment:
       One thing I want to ensure (since I'm not completely familiar with the 
error semantics of the functions in Python), is that this error will stop the 
pipeline from being submitted, and essentially be the equivalent of a C++ 
CheckFail? We want this error to stop everything, otherwise users might miss 
this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to