hermes85pl commented on a change in pull request #10433:
URL: https://github.com/apache/beam/pull/10433#discussion_r413106543
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -1317,8 +1341,10 @@ private String getDocumentMetadata(String document)
throws IOException {
spec.getTypeFn() != null ?
spec.getTypeFn().apply(parsedDocument) : null,
spec.getIdFn() != null ?
spec.getIdFn().apply(parsedDocument) : null,
spec.getUsePartialUpdate() ? DEFAULT_RETRY_ON_CONFLICT :
null);
+ SimpleModule module = new SimpleModule();
+ module.addSerializer(DocumentMetadata.class, new
DocumentMetadataSerializer());
+ OBJECT_MAPPER.registerModule(module);
Review comment:
This shouldn't be done **here**, should it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
