Hannah-Jiang commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r413244516



##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
 task copyThirdPartyLicenses(type: Copy) {
   from ("third_party_licenses")
   into "build/target/third_party_licenses"
+  doLast {
+    file('third_party_licenses').deleteDir()
+  }
 }
 
+def Boolean pull_licenses

Review comment:
       That was the behavior I observed when I implement it. But yesterday, 
when I try it again, it didn't work as expected. So I introduced the 
pull_licenses variable. But today, as you pointed out, I tried again, it 
worked! I reversed to original code. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to