udim commented on a change in pull request #11502:
URL: https://github.com/apache/beam/pull/11502#discussion_r414212691
##########
File path: sdks/java/container/license_scripts/license_script.sh
##########
@@ -15,39 +15,33 @@
# limitations under the License.
set -e
+ROOT_DIR=$(pwd)
+CONTAINER_DIR="$ROOT_DIR/sdks/java/container"
+
# reports are generated at ~/beam/java_third_party_licenses
./gradlew generateLicenseReport --rerun-tasks
-# install packages needed for pull_licenses_java.py
-pip install "beautifulsoup4>=4.9.0,<5.0"
-pip install "future>=0.16.0,<1.0.0"
-pip install "pyyaml>=3.12,<6.0.0"
-pip install "tenacity>=5.0.2,<6.0"
+# pip install 'tox>=3.14.6,<3.15.0'
+pip install --no-cache-dir tox==3.11.1
Review comment:
The virtualenv command should already be installed, and all the changes
it makes are limited to the given directory.
Once you run the `activate` command `pip install` will no longer change the
user environment.
Actually, according to Beam's guide, Python 3 already has a built-in
virtualenv tool:
```
python3 -m venv env && source env/bin/activate
```
https://beam.apache.org/documentation/sdks/python-dependencies/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
