tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416621001
##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
dockerfile project.file("./${dockerfileName}")
files "./build/"
+ buildArgs(['pull_licenses':
!project.rootProject.hasProperty(["no-licenses"])])
Review comment:
How about we call both flags 'pull_licenses' and add
"pull_licenses=true" to project root, with a comment what this flag does, and
how to disable it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]