ibzib commented on a change in pull request #11549:
URL: https://github.com/apache/beam/pull/11549#discussion_r416781568
##########
File path: CHANGES.md
##########
@@ -122,13 +122,22 @@ conversion to beam schema options. *Remark: Schema aware
is still experimental.*
values as strings) into Python native types that are written to Avro
(Python's date, datetime types, decimal, etc). For more information
see
https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro#avro_conversions.
+* Licenses/notices of third party dependencies are added to Java and Python
SDK docker images.
([BEAM-9136](https://issues.apache.org/jira/browse/BEAM-9136))
+
+ <b>Java SDK images</b>: By default, it checks if the licenses/notices are
pullable, instead of pulling the licenses/notices. In order to pull licenses,
`docker-pull-licenses` variable should ba passed.
Review comment:
```suggestion
<b>Java SDK images</b>: By default, it checks if the licenses/notices
are pullable, instead of pulling the licenses/notices. In order to pull
licenses, `docker-pull-licenses` variable should be passed.
```
##########
File path: CHANGES.md
##########
@@ -122,13 +122,22 @@ conversion to beam schema options. *Remark: Schema aware
is still experimental.*
values as strings) into Python native types that are written to Avro
(Python's date, datetime types, decimal, etc). For more information
see
https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro#avro_conversions.
+* Licenses/notices of third party dependencies are added to Java and Python
SDK docker images.
([BEAM-9136](https://issues.apache.org/jira/browse/BEAM-9136))
+
+ <b>Java SDK images</b>: By default, it checks if the licenses/notices are
pullable, instead of pulling the licenses/notices. In order to pull licenses,
`docker-pull-licenses` variable should ba passed.
+
+ <b>Python SDK images</b>: By default, it pulls licenses/notices of the
third party licenses.
+
+ If you want to create lightweight images or do not want to deal with
licenses, you can pass `no-licenses` variable when build docker images to skip
it.
Review comment:
This depends on #11548, right?
##########
File path: CHANGES.md
##########
@@ -122,13 +122,22 @@ conversion to beam schema options. *Remark: Schema aware
is still experimental.*
values as strings) into Python native types that are written to Avro
(Python's date, datetime types, decimal, etc). For more information
see
https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro#avro_conversions.
+* Licenses/notices of third party dependencies are added to Java and Python
SDK docker images.
([BEAM-9136](https://issues.apache.org/jira/browse/BEAM-9136))
+
+ <b>Java SDK images</b>: By default, it checks if the licenses/notices are
pullable, instead of pulling the licenses/notices. In order to pull licenses,
`docker-pull-licenses` variable should ba passed.
Review comment:
Please say what "it" refers to here (ie the Docker gradle task)
##########
File path: CHANGES.md
##########
@@ -122,13 +122,22 @@ conversion to beam schema options. *Remark: Schema aware
is still experimental.*
values as strings) into Python native types that are written to Avro
(Python's date, datetime types, decimal, etc). For more information
see
https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro#avro_conversions.
+* Licenses/notices of third party dependencies are added to Java and Python
SDK docker images.
([BEAM-9136](https://issues.apache.org/jira/browse/BEAM-9136))
+
+ <b>Java SDK images</b>: By default, it checks if the licenses/notices are
pullable, instead of pulling the licenses/notices. In order to pull licenses,
`docker-pull-licenses` variable should ba passed.
+
+ <b>Python SDK images</b>: By default, it pulls licenses/notices of the
third party licenses.
Review comment:
```suggestion
<b>Python SDK images</b>: By default, it pulls licenses/notices of the
third party dependencies.
```
##########
File path: website/src/documentation/runtime/environments.md
##########
@@ -119,6 +119,10 @@ To build Beam SDK container images:
./gradlew [--file=path/to/new/Dockerfile] :sdks:python:container buildAll
```
+From 2.21.0, licenses of third party dependencies were added to docker images
by default.
+If you want to creat lightweight images or do not like to deal with licenses,
`no-licenses` variable can be used to skip adding licenses.
Review comment:
```suggestion
If you want to create lightweight images or do not like to deal with
licenses, `no-licenses` variable can be used to skip adding licenses.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
