aromanenko-dev commented on a change in pull request #11341:
URL: https://github.com/apache/beam/pull/11341#discussion_r417339591



##########
File path: 
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsOptions.java
##########
@@ -103,6 +103,34 @@ public AWSCredentialsProvider create(PipelineOptions 
options) {
 
   void setClientConfiguration(ClientConfiguration clientConfiguration);

Review comment:
       I think it would be better to keep it for now to avoid breaking change. 
Perhaps, just add a comment that it's recommended to use new methods since they 
provide more functionality.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to