ananvay commented on a change in pull request #11452:
URL: https://github.com/apache/beam/pull/11452#discussion_r417515157
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -117,13 +117,15 @@ class DataflowRunner(PipelineRunner):
# TODO: Remove the apache_beam.pipeline dependency in
CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import
CombineValuesPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import
CreatePTransformOverride
- from apache_beam.runners.dataflow.ptransform_overrides import
ReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import
JrhReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import
ReadPTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import
NativeReadPTransformOverride
- # Thesse overrides should be applied before the proto representation of the
+ # These overrides should be applied before the proto representation of the
# graph is created.
_PTRANSFORM_OVERRIDES = [
- CombineValuesPTransformOverride()
+ CombineValuesPTransformOverride(),
Review comment:
Looking at other parts, seems like this would be the same for both? And
the only difference would be the JRH_PTRANSFORM_OVERRIDES section below (which
basically is JrhReadPTransformOverride)? I'm not sure why that Read override is
needed differently for JRH...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
