apilloud commented on pull request #11272: URL: https://github.com/apache/beam/pull/11272#issuecomment-622055322
Oops, forgot to include in my comments: ZetaSQL's range is much smaller than the underlying type, can you add a test or two for that? How do out of range values fail? (Also worth asking, do we need any special treatment for boundary conditions (`LocalDate.MIN`, `LocalDate.MAX`)? Probably not for now.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
