TheNeuralBit commented on a change in pull request #11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r418628471
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java
##########
@@ -257,10 +257,8 @@ private Transform(
// Combining over a single field, so extract just that field.
combined =
(combined == null)
- ? byFields.aggregateFieldBaseValue(
- inputs.get(0), combineFn, fieldAggregation.outputField)
- : combined.aggregateFieldBaseValue(
- inputs.get(0), combineFn, fieldAggregation.outputField);
+ ? byFields.aggregateField(inputs.get(0), combineFn,
fieldAggregation.outputField)
+ : combined.aggregateField(inputs.get(0), combineFn,
fieldAggregation.outputField);
Review comment:
What about adding the option for SqlTransform to convert unknown logical
types to their base type at the input? I think that behavior would be
effectively the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
