lostluck commented on a change in pull request #11553:
URL: https://github.com/apache/beam/pull/11553#discussion_r419623182
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -162,6 +168,14 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error {
return nil
}
+func rtErrHelper(err error) error {
+ if err != nil {
+ return err
+ } else {
+ return errors.New("RTracker IsDone failed for unspecified
reason")
+ }
Review comment:
```suggestion
}
return errors.New("RTracker.IsDone() failed for unspecified reason")
```
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -162,6 +168,14 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error {
return nil
}
+func rtErrHelper(err error) error {
+ if err != nil {
+ return err
+ } else {
+ return errors.New("RTracker IsDone failed for unspecified
reason")
+ }
Review comment:
Also, in both places this is called, error or no, we don't know IsDone
failed(), we know that the DoFn terminated without fully processing the
restriction (If I understand IsDone's semantics correctly). Perhaps the message
should indicate that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
