ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r419829971
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -784,7 +877,25 @@ public DataflowPipelineJob run(Pipeline pipeline) {
"Executing pipeline on the Dataflow Service, which will have billing
implications "
+ "related to Google Compute Engine usage and other Google Cloud
Services.");
- List<DataflowPackage> packages = options.getStager().stageDefaultFiles();
+ // Capture the sdkComponents for look up during step translations
+ SdkComponents sdkComponents = SdkComponents.create();
+
+ DataflowPipelineOptions dataflowOptions =
options.as(DataflowPipelineOptions.class);
+ String workerHarnessContainerImageURL =
DataflowRunner.getContainerImageForJob(dataflowOptions);
+ RunnerApi.Environment defaultEnvironmentForDataflow =
+ Environments.createDockerEnvironment(workerHarnessContainerImageURL);
+
+ sdkComponents.registerEnvironment(
+ defaultEnvironmentForDataflow
+ .toBuilder()
+ .addAllDependencies(getDefaultArtifacts())
+ .build());
+
+ RunnerApi.Pipeline pipelineProto = PipelineTranslation.toProto(pipeline,
sdkComponents, true);
+
+ LOG.debug("Portable pipeline proto:\n{}",
TextFormat.printToString(pipelineProto));
Review comment:
This debug log is not new. It's just relocated. Do you think it would be
better to remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
