darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624484915
> Thanks! > > In terms of naming, I found it surprising that union (for example) does deduplication. Maybe name them distinctUnion and multisetUnion or something like that? > Thanks! > > In terms of naming, I found it surprising that union (for example) does deduplication. Maybe name them distinctUnion and multisetUnion or something like that? I feel that As it is SetFns.union, it follows SET DISTINCT semantics. What is your view? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
