mxm commented on a change in pull request #11558:
URL: https://github.com/apache/beam/pull/11558#discussion_r420932855
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -455,6 +461,18 @@ public void open() throws Exception {
if (!options.getDisableMetrics()) {
flinkMetricContainer = new FlinkMetricContainer(getRuntimeContext());
doFnRunner = new DoFnRunnerWithMetricsUpdate<>(stepName, doFnRunner,
flinkMetricContainer);
+ String checkpointMetricNamespace =
Review comment:
Yes, I agree that we want this to be more generic. I didn't want to
mention the Flink metric reporter but I think that would introduce another
level of complexity. Not sure if that is the right tool for the job. I'd rather
query metrics through the job server and the rest api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
