robertwb commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r421878491
##########
File path: sdks/python/apache_beam/dataframe/transforms.py
##########
@@ -248,7 +261,12 @@ def _dict_union(dicts):
return result
-def _flatten(valueish, root=()):
+def _flatten(
+ valueish, # type: Union[T, Tuple[T, ...], Dict[Any, T]]
Review comment:
Generally I'd agree that `Iterable`/`Mapping` would be preferable, but
here I want to be restrictive about the kinds of values I decompose.
The keys types of the mapping would be `Union[None, int, U]`, so you'd have
to cast anyway, so I think it's simpler to leave as is.
Still, good food for thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
