chamikaramj commented on a change in pull request #11580:
URL: https://github.com/apache/beam/pull/11580#discussion_r421942845
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -288,6 +288,11 @@ public synchronized void close() {
source.stream.getName(),
fraction);
+ if (fraction <= 0.0 || fraction >= 1.0) {
+ LOG.info("BigQuery Storage API does not support splitting at fraction
{}", fraction);
Review comment:
What values did you observe ? It's surprising if you receive negative
values here for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
