kkucharc commented on a change in pull request #11567:
URL: https://github.com/apache/beam/pull/11567#discussion_r423014250
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -404,6 +419,77 @@ def save(self, results):
return self._client.insert_rows(self._bq_table, results)
+class InfluxDBMetricsPublisherOptions(object):
+ def __init__(
+ self,
+ measurement, # type: str
+ db_name, # type: str
+ hostname='http://localhost:8086', # type: str
Review comment:
Then maybe we should have param without default value? I can imagine
case when someone doesn't know why metrics tries to be saved to this host
without checking this code deeper?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
