chamikaramj commented on a change in pull request #11670:
URL: https://github.com/apache/beam/pull/11670#discussion_r424771303
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -123,20 +123,16 @@ class Pipeline(object):
should be used to designate new names
(e.g. ``input | "label" >> my_transform``).
"""
-
- # TODO: BEAM-9001 - set environment ID in all transforms and allow runners to
- # override.
@classmethod
Review comment:
Probably we can introduce a new visitor and update runners to use that
similar to following ?
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L557
But this is not a blocker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
