jaketf commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-628845239
[FhirIOReadIT](https://github.com/apache/beam/pull/11339/files#diff-7a1359c60a094e73275769adb69b35d3R57) borrows the [TestPubsubSignal](https://github.com/apache/beam/blob/44f3d3f2d52e93a34b05068bf76f6f9d2611bf77/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java) pattern from [PubsubReadIT](https://github.com/apache/beam/blob/a9e14ff7f4b1aafa9915cb95e1bb7e7d3ab6a28b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadIT.java#L41) This works fine on direct runner for me. It seems this is a dataflow runner / test pubsub signal thing. I will look into if I'm not closing some channel in my tests. @pabloem Have we seen anything flaky on this before? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
