robertwb commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426926720
##########
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java
##########
@@ -195,7 +187,7 @@ public void testFileWithExtensionPackageNamingAndSize()
throws Exception {
PackageAttributes attr = makePackageAttributes(tmpFile, null);
DataflowPackage target = attr.getDestination();
- assertThat(target.getName(), RegexMatcher.matches("file-" + HASH_PATTERN +
".txt"));
+ assertThat(target.getName(), RegexMatcher.matches(UUID_PATTERN + ".txt"));
Review comment:
Is it important, for the purposes of this test (or Dataflow in general)
that the staged file name is in the form of a UUID? If not (and I don't think
it is) it's better not to test for it. (A test that might be good to add is to
see if two same-named files in different directories actually get staged to
different places, which is the underlying, important intent.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
