TheNeuralBit commented on a change in pull request #11744:
URL: https://github.com/apache/beam/pull/11744#discussion_r427592587
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -164,10 +165,19 @@ def add_runner_options(parser):
all_options = self.options.get_all_options(
add_extra_args_fn=add_runner_options,
retain_unknown_options=self._retain_unknown_options)
+
# TODO: Define URNs for options.
# convert int values: https://issues.apache.org/jira/browse/BEAM-5509
+ def convert_pipeline_option_value(v):
+ if type(v) == int:
Review comment:
Oh the relevant jira is linked right there. It seems that this is really
a workaround for a bug in json_format where ints and floats aren't treated
differently. I can look into fixing that upstream so we can get rid of the
special case here.
I don't think it would be good to call str(v) on everything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
