boyuanzz commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632408026


   > What is the intrinsic limitation that did not allow old 
`OffsetRangeTracker` to be refactored for this use case? or why we want to have 
both?
   > 
   `GrowableOffsetRangeTracker` and `OffsetRangeTracker` should be applied to 
different kind of `OffsetRange`. `GrowableOffsetRangeTracker` is for the 
`OffsetRange` that the end could be changed during execution time, which mostly 
happens in streaming case. `OffsetRangeTracker` is for the range that we know 
what the exact end is, which is perfect for batch.  The reason that I didn't 
make them into one is because I don't want to introduce additional complexity 
to `OffsetRangeTracker`.  It's doable to have the dynamic one as general case 
where the range with fixed end is a special case. But I want to make them 
specifically with less confusion.
   
   > Does this mean also that we might need `GrowableBytekeyRangeTracker` and 
basically 'dynamic' versions for every `RestrictionTracker` ?
   
   I think it will depend on the actual usage. If we have an application 
scenario that requires for a dynamic version, then I would say yes. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to