aromanenko-dev commented on a change in pull request #11357:
URL: https://github.com/apache/beam/pull/11357#discussion_r431203774
##########
File path:
sdks/java/io/solr/src/test/java/org/apache/beam/sdk/io/solr/SolrIOTest.java
##########
@@ -155,6 +155,23 @@ public void testRead() throws Exception {
pipeline.run();
}
+ @Test
+ public void testReadAll() throws Exception {
+ SolrIOTestUtils.insertTestDocuments(SOLR_COLLECTION, NUM_DOCS, solrClient);
+
+ PCollection<SolrDocument> output =
+ pipeline
+ .apply(
+ Create.of(
+ SolrIO.read()
+ .withConnectionConfiguration(connectionConfiguration)
+ .from(SOLR_COLLECTION)
+ .withBatchSize(101)))
+ .apply(SolrIO.readAll());
+ PAssert.thatSingleton(output.apply("Count",
Count.globally())).isEqualTo(NUM_DOCS);
Review comment:
I believe we can improve this test in the future by reading with
multiple `Read`s (the goal of adding `readAll()`) and check the content of read
messages (not only count).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
