KevinGG commented on a change in pull request #11838:
URL: https://github.com/apache/beam/pull/11838#discussion_r431469495
##########
File path:
sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
##########
@@ -315,6 +327,7 @@ def read_multiple(self, labels):
StreamingCacheSource(self._cache_dir, l,
self._is_cache_complete).read(tail=True)
for l in labels
+ if not [sub_l for sub_l in l if self.sentinel_label() in sub_l]
Review comment:
This is a little hard to read.
Isn't a label `l` a `str`, so a `sub_l` is a character of that `str`?
I suppose `if not [sub_l for ...]` evaluates to `True` when the `[sub_l for
...]` is empty.
And the emptiness of `[sub_l for ...]` is based on whether the
`sentinel_label` exists in the `sub_l`? This is where I get confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
