tvalentyn commented on a change in pull request #11828:
URL: https://github.com/apache/beam/pull/11828#discussion_r431527674



##########
File path: release/src/main/scripts/deploy_pypi.sh
##########
@@ -41,9 +41,12 @@ fi
 mkdir ${LOCAL_CLONE_DIR}
 cd ${LOCAL_CLONE_DIR}
 
+virtualenv deploy_pypi_env
+source ./deploy_pypi_env/bin/activate
+pip install twine

Review comment:
       Consider making this in a /tmp directory or the directory that you 
create and later clean up (assuming it won't interfere with pypi uploads).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to