chamikaramj commented on a change in pull request #11814:
URL: https://github.com/apache/beam/pull/11814#discussion_r432014418
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##########
@@ -397,10 +397,21 @@ public static PackageAttributes forFileToStage(
String.format("Non-existent file to stage: %s",
file.getAbsolutePath()));
}
checkState(!file.isDirectory(), "Source file must not be a directory.");
+ String target;
+ switch (dest) {
+ case "dataflow-worker.jar":
Review comment:
Can we add a log statement describing why we need special treatment for
these jars ? I see these jars being specifically being referenced to in
Dataflow boot.go files.May be that's why ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
