tvalentyn commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r432107251
##########
File path:
.test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json
##########
@@ -77,7 +77,7 @@
],
"orderByTime": "ASC",
"policy": "default",
- "query": "SELECT mean(\"value\") FROM \"wordcount_py27_results\"
WHERE metric = 'Python performance test' AND $timeFilter GROUP BY
time($__interval), \"metric\"",
+ "query": "SELECT mean(\"value\") FROM \"wordcount_py27_results\"
WHERE metric = 'wordcount_it_runtime' AND $timeFilter GROUP BY
time($__interval), \"metric\"",
Review comment:
Seeing this query now - yes, I wound just keep the metric 'runtime',
since we already know it is wordcount_py27_results, and it would be simpler
that pipeline does not need to know the name of the suite. In the future we
might add different metrics like 'cost' or total cputime consumed by other
workers as opposed to runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
