purbanow commented on a change in pull request #11794:
URL: https://github.com/apache/beam/pull/11794#discussion_r432423695
##########
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##########
@@ -257,23 +301,12 @@
}
/**
- * Name of the cloud bucket (GCS by now) to use as tmp location of CSVs
during COPY statement.
- *
- * @param stagingBucketName - String with the name of the bucket.
- */
- public Read<T> withStagingBucketName(String stagingBucketName) {
- return toBuilder().setStagingBucketName(stagingBucketName).build();
- }
-
- /**
- * Name of the Storage Integration in Snowflake to be used. See
- *
https://docs.snowflake.com/en/sql-reference/sql/create-storage-integration.html
for
- * reference.
+ * A location object which contains connection config between Snowflake
and GCP.
*
- * @param integrationName - String with the name of the Storage
Integration.
+ * @param location - an instance of {@link Location}.
*/
- public Read<T> withIntegrationName(String integrationName) {
- return toBuilder().setIntegrationName(integrationName).build();
+ public Read<T> via(Location location) {
Review comment:
No reason. I changed to `withLocation ` to be more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
