echauchot commented on a change in pull request #11732:
URL: https://github.com/apache/beam/pull/11732#discussion_r432455805
##########
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##########
@@ -330,6 +331,24 @@ private CassandraIO() {}
return builder().setMinNumberOfSplits(minNumberOfSplits).build();
}
+ /** Cassandra client socket option to set the connect timeout. */
+ public Read<T> withConnectTimeout(Integer timeout) {
+ return withConnectTimeout(ValueProvider.StaticValueProvider.of(timeout));
Review comment:
Add two checkArgument as in the other with* methods one for null and one
for >0. Also I wrote a error above: valueprovider version is the low level
method, the other relies on it. So it is in the valueprovider version you need
to put the checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
