youngoli commented on pull request #11870: URL: https://github.com/apache/beam/pull/11870#issuecomment-636284163
As a note for what still needs to be done: * Unit tests for this code * I'd like to separate the CountElms aggregation into Beam, alongside the existing Count (which works per-key). * The count PAssert needs to be changed to have its own error message, instead of using passert.Equals. From personal experience, using the passert.Equals error message is really unclear when there's an error. CC: @lostluck Take a look if you want, but don't worry about reviewing yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
