dmvk commented on a change in pull request #11874:
URL: https://github.com/apache/beam/pull/11874#discussion_r433872630
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTranslationContext.java
##########
@@ -68,13 +71,18 @@ public FlinkBatchTranslationContext(ExecutionEnvironment
env, PipelineOptions op
this.danglingDataSets = new HashMap<>();
}
+ void init(Pipeline pipeline) {
+ pipeline.traverseTopologically(countingPipelineVisitor);
+ pipeline.traverseTopologically(lookupPipelineVisitor);
+ }
+
// ------------------------------------------------------------------------
- public Map<PValue, DataSet<?>> getDanglingDataSets() {
+ Map<PValue, DataSet<?>> getDanglingDataSets() {
Review comment:
The whole class is marked as package private, so this change should not
make any difference when it comes to 3rd code. Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
