amaliujia commented on a change in pull request #11895:
URL: https://github.com/apache/beam/pull/11895#discussion_r434095216



##########
File path: 
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlOperators.java
##########
@@ -72,6 +82,23 @@ public static SqlFunction createSimpleSqlFunction(String 
name, SqlTypeName retur
         SqlFunctionCategory.USER_DEFINED_FUNCTION);
   }
 
+  public static SqlUserDefinedAggFunction createUdafOperator(
+      String name,
+      SqlReturnTypeInference returnTypeInference,
+      AggregateFunction function) {
+    return new SqlUserDefinedAggFunction(

Review comment:
       Nice. By doing so it becomes a extensible way to define other AGG 
functions that Calcite does not have.
   
   Glad you figured it out.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to