robertwb commented on a change in pull request #11785:
URL: https://github.com/apache/beam/pull/11785#discussion_r434143456



##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -242,6 +242,11 @@ def __init__(self, env, use_beam=True, **kwargs):
         **kwargs)
 
   def run(self, test, **kwargs):
+    for example in test.examples:
+      if example.exc_msg is None:
+        # Don't fail doctests that raise this error.
+        example.exc_msg = (
+            'apache_beam.dataframe.frame_base.WontImplementError: ...')

Review comment:
       Correct, but I only know that from reading the code. (The implementation 
doesn't have any ability to customize this, e.g. the OutputChecker doesn't get 
invoked on exceptional case.) I decided depending on this was preferable to 
copying and modifying the implementation. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to