pabloem commented on a change in pull request #11898:
URL: https://github.com/apache/beam/pull/11898#discussion_r434172894
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1702,7 +1702,8 @@ def _get_destination_uri(self, temp_location):
logging.debug("gcs_location is empty, using temp_location instead")
else:
raise ValueError(
- '{} requires a GCS location to be provided'.format(
+ '{} requires a GCS location to be provided. Neither option'
+ '--gcs_location nor the fallback --temp_location is set.'.format(
Review comment:
`gcs_location` is not a pipeline option. It's a constructor argument.
Can you error out as such?
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
##########
@@ -243,7 +243,8 @@ public void validate(PipelineOptions options) {
}
checkArgument(
!Strings.isNullOrEmpty(tempLocation),
- "BigQueryIO.Write needs a GCS temp location to store temp files.");
+ "BigQueryIO.Write needs a GCS temp location to store temp files."
+ + "This can be set with option --tempLocation.");
Review comment:
Please document customGcs location method as well. Thanks!
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -941,7 +941,8 @@ public void validate(PipelineOptions options) {
String tempLocation = bqOptions.getTempLocation();
checkArgument(
!Strings.isNullOrEmpty(tempLocation),
- "BigQueryIO.Read needs a GCS temp location to store temp files.");
+ "BigQueryIO.Read needs a GCS temp location to store temp files."
+ + "This can be set with option --tempLocation.");
Review comment:
Java also has the ability to provide a custom gcs location. Can you
document it as well?
https://github.com/apache/beam/blob/0a0399f71cf14ecabe7e73b6cd596325bb7ff2ea/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java#L2314-L2317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
