lukecwik commented on a change in pull request #11873:
URL: https://github.com/apache/beam/pull/11873#discussion_r434197026
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -1353,14 +1353,14 @@ public void translate(StreamingPubsubIORead transform,
TranslationContext contex
PropertyNames.PUBSUB_ID_ATTRIBUTE,
overriddenTransform.getIdAttribute());
}
// In both cases, the transform needs to read PubsubMessage. However, in
case it needs
- // the attributes, we supply an identity "parse fn" so the worker will
read PubsubMessage's
- // from Windmill and simply pass them around; and in case it doesn't
need attributes,
- // we're already implicitly using a "Coder" that interprets the data as
a PubsubMessage's
- // payload.
- if (overriddenTransform.getNeedsAttributes()) {
+ // the attributes or messageId, we supply an identity "parse fn" so the
worker will
+ // read PubsubMessage's from Windmill and simply pass them around; and
in case it
+ // doesn't need attributes, we're already implicitly using a "Coder"
that interprets
+ // the data as a PubsubMessage's payload.
+ if (overriddenTransform.getNeedsAttributes() |
overriddenTransform.getNeedsMessageId()) {
Review comment:
Other then this change, this looks good to me. We'll see what the tests
have to say.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
