ibzib commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434844066
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
-Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
-Prelease.useAutomaticVersion=true --info --no-daemon
- echo "Please make sure gradle release succeed: "
- echo "1. release code has been pushed to github repo."
- echo "2. new rc tag has created in github."
+ git push "v${RELEASE}-RC${RC_NUM}"
Review comment:
> When I did this locally there was one more commit on the
release-2.22.0 branch changing the version to 2.22.0-SNAPSHOT, so I had to run
git push origin release-2.22.0 as well.
I see two commits, one changing it to RC1 and next changing it back to
SNAPSHOT. Isn't that just a no-op?
https://github.com/apache/beam/commits/release-2.22.0
> Also is it ok to omit the origin?
Origin is the default IIUC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
