damondouglas commented on a change in pull request #11883: URL: https://github.com/apache/beam/pull/11883#discussion_r435349866
########## File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go ########## @@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA, accumB averageAccum) averageAccum } } -func (c *averageFn) ExtractOutput(accum averageAccum) float64 { +func (c *averageFn) ExtractOutput(accum averageAccum) int { Review comment: Thank you, Henry. Are we ok with this then? ``` func (c *averageFn) ExtractOutput(accum averageAccum) float64 { if accum.Count == 0 { return 0 } return float64(accum.Sum / accum.Count) } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org