boyuanzz commented on a change in pull request #11894:
URL: https://github.com/apache/beam/pull/11894#discussion_r436068037
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner_test.py
##########
@@ -377,11 +377,6 @@ def process_timer(
assert_that(actual, equal_to(expected))
def test_pardo_timers_clear(self):
- if type(self).__name__ != 'FlinkRunnerTest':
Review comment:
We have problems if overriding subclass. The `PortableRunnerTest`
doesn't support clearing timer, but its subclass `FlinkRunnerTest` and
`SparkRunnerTest` support it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
