kennknowles commented on pull request #11820:
URL: https://github.com/apache/beam/pull/11820#issuecomment-639689286
PTAL. The first commit is unchanged, the second is a total rewrite (or
unwrite, if you like).
- Modified each `SqlQuery2`, etc, class to have just the amount of
variation necessary
- Made each test class run as `@Enclosed` with an inner class for each
dialect. I don't love this use of inheritance, but it seems to be how JUnit
wants things. It has a clearer test signal than using `@Parameterized` across
the dialects, and allows separate `@Ignore` for broken/unsupported features.
Did not do:
- Jenkins job to publish benchmarks; planning that as a followup
- Any other refactor to make suites more manageable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
