aaltay edited a comment on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-641482606
This looks nice. I have a few clarifiying questions: on pull_request: This is good. Would it trigger on every pull request. This may not be needed. I am not sure what GH resource we will have and what kind of queue there will be. We would not want ot add test load to all PRs. Questions: - Can we trigger this with a phrase? And/Or limit it to python changes? - What is gh-action artifacts? How does one access this to get the artifacts? on push: Question: - What is release-candidate branches? It is release-* ? (If yes, this looks good.) on schedule: this looks good. Other questions: - How do we use cancel previous runs workflow? Does it work automatically? (If yes, this is great.) > Nightly is addressed by on schedule trigger. +1. > I investigated triggering builds manually by using repository_dispatch and curl however build triggered by it is executed on master branch and I think there is no convenient way to run it on different branches. If your question is related to "Build Release Candidate" phase it may be solved here as well since build will be triggered during pushing to master/release/release-candidate branches (and related to it by commit hash). Yes, I think this works. My question was how could a release manager build wheels. Release manager will push some commits but they will not do this using a PR. Would it still trigger builds? And release manager might want to build release at a specific commit in the release branch could they do this by opening a PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
