robinyqiu commented on pull request #11957: URL: https://github.com/apache/beam/pull/11957#issuecomment-641627057
Well. Some tests are failing and I realized this turns out to be not that simple change. There are subtle differences between Beam schema and ZetaSQL struct that prevents this change (e.g. if ZetaSQL types are by default nullable whereas it is a label in Beam field type; and ZetaSQL struct allows fields with same name but Beam does not). I will take more time to figure out what is the correct thing to do here. In the meanwhile, I will send out some other small cleanup PRs for review. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
