TobKed edited a comment on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-641886596
@aaltay thank you for review. Answers for your questions: > on pull_request: > Can we trigger this with a phrase? And/Or limit it to python changes? I added `paths` for filtering so only meaningful changes will trigger build check. https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths. > What is gh-action artifacts? How does one access this to get the artifacts? GitHub Action artifacts allow to persist data on storage space to share that data with another job. They can be downloaded from GitHub UI for by API. GitHub stores artifacts for 90 days You can test it on example run: https://github.com/TobKed/beam/actions/runs/129158855 [GitHub Actions Artifacts documentation](https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts#about-workflow-artifacts) [GitHub API - Download an artifact](https://developer.github.com/v3/actions/artifacts/#download-an-artifact) > How do we use cancel previous runs workflow? Does it work automatically? (If yes, this is great.) It is done automatically in `.gihub/workflows/cancel.yml` with usage of https://github.com/styfle/cancel-workflow-action. This action is checking is there any other previously triggered and running workflow on given branch and cancel them. It saves resources and prevents colliding actions on GCS bucket. > What is release-candidate branches? It is release-* ? (If yes, this looks good.) I think I made mistake here. To be precise `release-*` branch is called `RELEASE_BRANCH` (based on [build_release_candidate.sh#L57](https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh#L57)) and based on [build_release_candidate.sh#L110](https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh#L110) proper pattern for release-candidate branches should be: `v*` (previously this pattern was for `tags` only) Edit: `v*` seems to be too general for branch, i change it to `v**-RC*` > Release manager will push some commits but they will not do this using a PR. Would it still trigger builds? And release manager might want to build release at a specific commit in the release branch could they do this by opening a PR? Currently source files are build here [build_release_candidate.sh#L174](https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh#L174) based on RELEASE_BRANCH, the release branch is created few lines above [build_release_candidate.sh#L109](https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh#L109), this push will trigger build of python sources and wheels. Build can be triggered in both ways: by pushing to branches matching patterns or creating PRs to these branches (however due to path filtering build on pull request may be not triggered). I hope it answers your questions :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
